[PATCH v2 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-03-29 Thread Taylor Blau
`git config` has long allowed the ability for callers to provide a 'type specifier', which instructs `git config` to (1) ensure that incoming values are satisfiable under that type, and (2) that outgoing values are canonicalized under that type. In another series, we propose to add extend this fun

Re: [PATCH v2 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-03-29 Thread René Scharfe
Am 30.03.2018 um 07:28 schrieb Taylor Blau: > diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt > index e09ed5d7d..9956b03f7 100644 > --- a/Documentation/git-config.txt > +++ b/Documentation/git-config.txt > @@ -160,30 +158,34 @@ See also <>. > --list:: > List all var

Re: [PATCH v2 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-03-30 Thread Jeff King
On Fri, Mar 30, 2018 at 01:28:30AM -0400, Taylor Blau wrote: > +static int option_parse_type(const struct option *opt, const char *arg, > + int unset) > +{ > + int *type = opt->value; > + > + if (!strcmp(arg, "bool")) > + *type = TYPE_BOOL; > + else