Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-26 Thread brian m. carlson
On Sat, Apr 25, 2015 at 06:03:22PM +0200, Torsten Bögershausen wrote: (I'm not sute if the commit message describes the problem deep enough for readers which are not familar with all the details of the original report): A feature implemented for Windows may break things for e.g. Linux users)

Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-25 Thread Torsten Bögershausen
On 2015-04-25 00.28, brian m. carlson wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH. However, the match was done by checking for plink case-insensitively in the string, which led to false

[PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread brian m. carlson
The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH. However, the match was done by checking for plink case-insensitively in the string, which led to false positives when GIT_SSH contained uplink. Improve

Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread brian m. carlson
On Fri, Apr 24, 2015 at 03:46:30PM -0700, Pete Harlan wrote: On Fri, Apr 24, 2015 at 3:28 PM, brian m. carlson sand...@crustytoothpaste.net wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH.

Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread Pete Harlan
On Fri, Apr 24, 2015 at 3:28 PM, brian m. carlson sand...@crustytoothpaste.net wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH. However, the match was done by checking for plink