Re: [PATCH v2 2/2] connect.c: replace signal() with sigaction()

2014-05-31 Thread Jeremiah Mahler
Chris, On Sat, May 31, 2014 at 10:39:39PM +1200, Chris Packham wrote: > On 31/05/14 08:58, Jeremiah Mahler wrote: > > From signal(2) man page: > > ... > > - signal(SIGCHLD, SIG_DFL); > > + memset(&sa, 0, sizeof(sa)); > > + sa.sa_handler = SIG_DFL; > > + sigaction(SIGCHLD, &sa, 0); > > I

Re: [PATCH v2 2/2] connect.c: replace signal() with sigaction()

2014-05-31 Thread Chris Packham
On 31/05/14 08:58, Jeremiah Mahler wrote: > From signal(2) man page: > > The behavior of signal() varies across UNIX versions, and has also var‐ > ied historically across different versions of Linux. Avoid its use: > use sigaction(2) instead. > > Replaced signal() with sigaction() in co

Re: [PATCH v2 2/2] connect.c: replace signal() with sigaction()

2014-05-30 Thread Andreas Schwab
Jeremiah Mahler writes: > From signal(2) man page: > > The behavior of signal() varies across UNIX versions, and has also var‐ > ied historically across different versions of Linux. Avoid its use: > use sigaction(2) instead. I don't think this matters for SIG_DFL or SIG_IGN. Andreas.

[PATCH v2 2/2] connect.c: replace signal() with sigaction()

2014-05-30 Thread Jeremiah Mahler
>From signal(2) man page: The behavior of signal() varies across UNIX versions, and has also var‐ ied historically across different versions of Linux. Avoid its use: use sigaction(2) instead. Replaced signal() with sigaction() in connect.c Signed-off-by: Jeremiah Mahler --- connect.c