Re: [PATCH v2 2/2] git-p4: handle "Translation of file content failed"

2015-09-16 Thread Lars Schneider
On 16 Sep 2015, at 00:12, Luke Diamand wrote: > On 15/09/15 16:38, Lars Schneider wrote: >> >> On 15 Sep 2015, at 08:43, Luke Diamand wrote: >> > > >>> Do we know the mechanism by which we end up in this state? >> Unfortunately no. I tried hard to

Re: [PATCH v2 2/2] git-p4: handle "Translation of file content failed"

2015-09-15 Thread Luke Diamand
On 15/09/15 16:38, Lars Schneider wrote: On 15 Sep 2015, at 08:43, Luke Diamand wrote: Do we know the mechanism by which we end up in this state? Unfortunately no. I tried hard to reproduce the error with “conventional” methods. As you can see I ended up manipulating

Re: [PATCH v2 2/2] git-p4: handle "Translation of file content failed"

2015-09-15 Thread Luke Diamand
On 14/09/15 17:55, larsxschnei...@gmail.com wrote: From: Lars Schneider A P4 repository can get into a state where it contains a file with type UTF-16 that does not contain a valid UTF-16 BOM. If git-p4 Sorry - what's a BOM? I'm assuming it's not a Bill of

Re: [PATCH v2 2/2] git-p4: handle "Translation of file content failed"

2015-09-15 Thread Lars Schneider
On 15 Sep 2015, at 08:43, Luke Diamand wrote: > On 14/09/15 17:55, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> A P4 repository can get into a state where it contains a file with >> type UTF-16 that does not contain a valid UTF-16

[PATCH v2 2/2] git-p4: handle "Translation of file content failed"

2015-09-14 Thread larsxschneider
From: Lars Schneider A P4 repository can get into a state where it contains a file with type UTF-16 that does not contain a valid UTF-16 BOM. If git-p4 attempts to retrieve the file then the process crashes with a "Translation of file content failed" error. Fix this by