Re: [PATCH v2 2/2] sequencer: fix quoting in write_author_script

2018-08-01 Thread Eric Sunshine
On Wed, Aug 1, 2018 at 11:50 AM Phillip Wood wrote: > On 31/07/18 22:39, Eric Sunshine wrote: > > On Tue, Jul 31, 2018 at 7:15 AM Phillip Wood > > wrote: > >> + /* > >> +* write_author_script() used to fail to terminate the > >> GIT_AUTHOR_DATE > >> +* line with a "'" and

Re: [PATCH v2 2/2] sequencer: fix quoting in write_author_script

2018-08-01 Thread Phillip Wood
On 31/07/18 22:39, Eric Sunshine wrote: On Tue, Jul 31, 2018 at 7:15 AM Phillip Wood wrote: Single quotes should be escaped as \' not \\'. Note that this only affects authors that contain a single quote and then only external scripts that read the author script and users whose git is upgraded

Re: [PATCH v2 2/2] sequencer: fix quoting in write_author_script

2018-08-01 Thread Junio C Hamano
Phillip Wood writes: >> Is the: >> >> ...for some reason sq_dequote() called by read_author_ident() >> seems to handle the broken quoting correctly. >> >> bit outdated? We know now from patch 2/4 of my series[1] that >> read_author_ident() wasn't handling it correctly at all. It was

Re: [PATCH v2 2/2] sequencer: fix quoting in write_author_script

2018-08-01 Thread Phillip Wood
Hi Eric On 31/07/18 22:39, Eric Sunshine wrote: On Tue, Jul 31, 2018 at 7:15 AM Phillip Wood wrote: Single quotes should be escaped as \' not \\'. Note that this only affects authors that contain a single quote and then only external scripts that read the author script and users whose git is

Re: [PATCH v2 2/2] sequencer: fix quoting in write_author_script

2018-07-31 Thread Eric Sunshine
On Tue, Jul 31, 2018 at 7:15 AM Phillip Wood wrote: > Single quotes should be escaped as \' not \\'. Note that this only > affects authors that contain a single quote and then only external > scripts that read the author script and users whose git is upgraded from > the shell version of rebase -i

[PATCH v2 2/2] sequencer: fix quoting in write_author_script

2018-07-31 Thread Phillip Wood
From: Phillip Wood Single quotes should be escaped as \' not \\'. Note that this only affects authors that contain a single quote and then only external scripts that read the author script and users whose git is upgraded from the shell version of rebase -i while rebase was stopped. This is