Re: [PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

Hi Junio, On Mon, 26 Oct 2015, Junio C Hamano wrote: > I asked Dscho if the shell is done correctly _for_ the platform. This assumes that the platform is either CR/LF or LF. That is incorrect. Windows does *not* dictate the line endings to be CR/LF. Certain applications do. The shell is an

Re: [PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

Junio C Hamano writes: > Matthieu Moy writes: > >> Johannes Schindelin writes: >> >>> This is the correct thing to do, really: we already specify LF as >>> field separator. >> >> I'm almost convinced that this is the

Re: [PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

Hi Junio, On Mon, 26 Oct 2015, Junio C Hamano wrote: > Subject: [PATCH] rebase-i: work around Windows CRLF line endings > > Editors on Windows can and do save text files with CRLF line > endings, which is the convention on the platform. We are seeing > reports that the "read" command in a port

Re: [PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

Johannes Schindelin writes: > This assumes that the platform is either CR/LF or LF. That is incorrect. > Windows does *not* dictate the line endings to be CR/LF. Certain > applications do. > > The shell is an MSys2 shell, and MSys2 convention is to use LF. Hence the >

Re: [PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

Johannes Schindelin writes: > This is the correct thing to do, really: we already specify LF as > field separator. I'm almost convinced that this is the right thing to do in the long run ("almost" because I'm not sure, not because I have arguments against). I agree

Re: [PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

Junio C Hamano writes: > Something along the line of the following would be tolerable, even > though I think in the longer term, not just in Git land but in the > larger ecosystem to use POSIXy tools on Windows, the best solution > is to fix the shell so that it matches the

Re: [PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

Matthieu Moy writes: > Johannes Schindelin writes: > >> This is the correct thing to do, really: we already specify LF as >> field separator. > > I'm almost convinced that this is the right thing to do in the long run > ("almost" because

[PATCH v2 2/2] sh-setup: explicitly mark CR as a field separator

This is the correct thing to do, really: we already specify LF as field separator. Incidentally, this fixes the problem interactive rebase has when the editor wants to save text with CR/LF line endings, as WordPad does in Windows 10. Signed-off-by: Johannes Schindelin