Re: [PATCH v2 2/5] builtin/config.c: support `--type=` as preferred alias for `--`

2018-04-26 Thread Eric Sunshine
On Thu, Apr 26, 2018 at 1:58 AM, Taylor Blau wrote: > `git config` has long allowed the ability for callers to provide a 'type > specifier', which instructs `git config` to (1) ensure that incoming > values can be interpreted as that type, and (2) that outgoing values are >

Re: [PATCH v2 2/5] builtin/config.c: support `--type=` as preferred alias for `--`

2018-04-26 Thread Junio C Hamano
Taylor Blau writes: > +static int option_parse_type(const struct option *opt, const char *arg, > + int unset) > +{ > + /* > + * To support '--' style flags, begin with new_type equal to > + * opt->defval. > + */ > + int new_type

[PATCH v2 2/5] builtin/config.c: support `--type=` as preferred alias for `--`

2018-04-25 Thread Taylor Blau
`git config` has long allowed the ability for callers to provide a 'type specifier', which instructs `git config` to (1) ensure that incoming values can be interpreted as that type, and (2) that outgoing values are canonicalized under that type. In another series, we propose to extend this