Re: [PATCH v2 2/6] builtin/am: make sure state files are text

Jeff King p...@peff.net writes: On Mon, Aug 24, 2015 at 01:58:06PM -0700, Junio C Hamano wrote: We forgot to terminate the payload given to write_file() with LF, resulting in files that end with an incomplete line. Teach the wrappers builtin/am uses to make sure it adds LF at the end as

Re: [PATCH v2 2/6] builtin/am: make sure state files are text

On Tue, Aug 25, 2015 at 09:19:13AM -0700, Junio C Hamano wrote: As to flags exposed to callers vs with and without gently, when we change the system to allow new modes of operations (e.g. somebody wants to write a binary file, or allocate more flag bits for their special case), I'd expect

Re: [PATCH v2 2/6] builtin/am: make sure state files are text

Jeff King p...@peff.net writes: On Tue, Aug 25, 2015 at 09:19:13AM -0700, Junio C Hamano wrote: As to flags exposed to callers vs with and without gently, when we change the system to allow new modes of operations (e.g. somebody wants to write a binary file, or allocate more flag bits for

[PATCH v2 2/6] builtin/am: make sure state files are text

We forgot to terminate the payload given to write_file() with LF, resulting in files that end with an incomplete line. Teach the wrappers builtin/am uses to make sure it adds LF at the end as necessary. Signed-off-by: Junio C Hamano gits...@pobox.com --- builtin/am.c | 10 -- 1 file

Re: [PATCH v2 2/6] builtin/am: make sure state files are text

On Mon, Aug 24, 2015 at 01:58:06PM -0700, Junio C Hamano wrote: We forgot to terminate the payload given to write_file() with LF, resulting in files that end with an incomplete line. Teach the wrappers builtin/am uses to make sure it adds LF at the end as necessary. Is it even worth doing