Re: [PATCH v2 21/22] mingw32: add uname()

2014-11-09 Thread Duy Nguyen
On Sun, Nov 9, 2014 at 10:32 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Sat, Nov 8, 2014 at 4:39 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- diff --git a/compat/mingw.c b/compat/mingw.c index c5c37e5..b817678 100644

Re: [PATCH v2 21/22] mingw32: add uname()

2014-11-09 Thread Torsten Bögershausen
On 2014-11-09 09.36, Duy Nguyen wrote: On Sun, Nov 9, 2014 at 10:32 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Sat, Nov 8, 2014 at 4:39 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- diff --git a/compat/mingw.c

Re: [PATCH v2 21/22] mingw32: add uname()

2014-11-09 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: strcpy() maybe? It was originally strcpy, then I wanted to get fancy and show Win3.1, Win95... but it got complicated (couldn't just do it based on the last bit of 'v'). Will revert. Why not use strlcpy() ? (This feels little like an overkill,

[PATCH v2 21/22] mingw32: add uname()

2014-11-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- compat/mingw.c | 11 +++ compat/mingw.h | 9 + 2 files changed, 20 insertions(+) diff --git a/compat/mingw.c b/compat/mingw.c index c5c37e5..b817678 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -2128,3 +2128,14 @@

Re: [PATCH v2 21/22] mingw32: add uname()

2014-11-08 Thread Eric Sunshine
On Sat, Nov 8, 2014 at 4:39 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- diff --git a/compat/mingw.c b/compat/mingw.c index c5c37e5..b817678 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -2128,3 +2128,14 @@ void