Re: [PATCH v2 22/22] untracked cache: guard and disable on system changes

2014-11-10 Thread Torsten Bögershausen
On 11/10/2014 12:47 AM, Duy Nguyen wrote: Some updates from the test lab, Windows 7 Working means git update-index --untracked-cache reports Testing...OK Rejected means ..does not change.. cygwin + NTFS: Working cygwin + VFAT: Rejected The same good news for Msysgit, running your github branch

Re: [PATCH v2 22/22] untracked cache: guard and disable on system changes

2014-11-09 Thread Duy Nguyen
On Sun, Nov 9, 2014 at 10:39 AM, Eric Sunshine sunsh...@sunshineco.com wrote: --- a/test-dump-untracked-cache.c +++ b/test-dump-untracked-cache.c @@ -44,6 +44,7 @@ int main(int ac, char **av) { struct untracked_cache *uc; struct strbuf base = STRBUF_INIT; +

Re: [PATCH v2 22/22] untracked cache: guard and disable on system changes

2014-11-09 Thread Torsten Bögershausen
On 2014-11-08 10.39, Nguyễn Thái Ngọc Duy wrote: If the user enables untracked cache, then - move worktree to an unsupported filesystem How do we detect this move ? Shouldn't we be able to detect an unsupported file system (by probing if stat(root_dir_of_repo) ==

Re: [PATCH v2 22/22] untracked cache: guard and disable on system changes

2014-11-09 Thread Duy Nguyen
On Mon, Nov 10, 2014 at 4:39 AM, Torsten Bögershausen tbo...@web.de wrote: On 2014-11-08 10.39, Nguyễn Thái Ngọc Duy wrote: If the user enables untracked cache, then - move worktree to an unsupported filesystem How do we detect this move ? Shouldn't we be able to detect an unsupported file

[PATCH v2 22/22] untracked cache: guard and disable on system changes

2014-11-08 Thread Nguyễn Thái Ngọc Duy
If the user enables untracked cache, then - move worktree to an unsupported filesystem - or simply upgrade OS - or move the whole (portable) disk from one machine to another - or access a shared fs from another machine there's no guarantee that untracked cache can still function properly.

Re: [PATCH v2 22/22] untracked cache: guard and disable on system changes

2014-11-08 Thread Eric Sunshine
On Sat, Nov 8, 2014 at 4:39 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: If the user enables untracked cache, then - move worktree to an unsupported filesystem - or simply upgrade OS - or move the whole (portable) disk from one machine to another - or access a shared fs from another