Re: [PATCH v2 28/34] run_command_opt(): optionally hide stderr when the command succeeds

2017-01-02 Thread Johannes Schindelin
Hi Hannes, On Wed, 14 Dec 2016, Johannes Sixt wrote: > Am 14.12.2016 um 14:06 schrieb Jeff King: > > On Wed, Dec 14, 2016 at 07:53:23AM -0500, Jeff King wrote: > > > > > I don't have a strong opinion on the patches under discussion, but > > > here are a few pointers on the run-command interface:

Re: [PATCH v2 28/34] run_command_opt(): optionally hide stderr when the command succeeds

2016-12-14 Thread Johannes Sixt
Am 14.12.2016 um 14:06 schrieb Jeff King: On Wed, Dec 14, 2016 at 07:53:23AM -0500, Jeff King wrote: On Wed, Dec 14, 2016 at 09:34:20AM +0100, Johannes Sixt wrote: I wanted to see what it would look like if we make it the caller's responsibility to throw away stderr. The patch is below, as fi

Re: [PATCH v2 28/34] run_command_opt(): optionally hide stderr when the command succeeds

2016-12-14 Thread Jeff King
On Wed, Dec 14, 2016 at 07:53:23AM -0500, Jeff King wrote: > On Wed, Dec 14, 2016 at 09:34:20AM +0100, Johannes Sixt wrote: > > > I wanted to see what it would look like if we make it the caller's > > responsibility to throw away stderr. The patch is below, as fixup > > of patch 29/34. The change

Re: [PATCH v2 28/34] run_command_opt(): optionally hide stderr when the command succeeds

2016-12-14 Thread Jeff King
On Wed, Dec 14, 2016 at 09:34:20AM +0100, Johannes Sixt wrote: > I wanted to see what it would look like if we make it the caller's > responsibility to throw away stderr. The patch is below, as fixup > of patch 29/34. The change is gross, but the end result is not that > bad, though not really a d

Re: [PATCH v2 28/34] run_command_opt(): optionally hide stderr when the command succeeds

2016-12-14 Thread Johannes Sixt
Am 13.12.2016 um 16:32 schrieb Johannes Schindelin: > This will be needed to hide the output of `git commit` when the > sequencer handles an interactive rebase's script. > > Signed-off-by: Johannes Schindelin > --- > run-command.c | 23 +++ > run-command.h | 1 + > 2 files c

[PATCH v2 28/34] run_command_opt(): optionally hide stderr when the command succeeds

2016-12-13 Thread Johannes Schindelin
This will be needed to hide the output of `git commit` when the sequencer handles an interactive rebase's script. Signed-off-by: Johannes Schindelin --- run-command.c | 23 +++ run-command.h | 1 + 2 files changed, 24 insertions(+) diff --git a/run-command.c b/run-command.c