Re: [PATCH v2 3/4] stripspace: Implement --count-lines option

On 2015-10-18 at 19:18:53 +0200, Junio C Hamano wrote: > Eric Sunshine writes: > > > Is there any application beyond git-rebase--interactive where a > > --count-lines options is expected to be useful? It's not obvious from > > the commit message that

Re: [PATCH v2 3/4] stripspace: Implement --count-lines option

On 2015-10-18 at 01:57:57 +0200, Eric Sunshine wrote: > On Fri, Oct 16, 2015 at 11:16 AM, Tobias Klauser wrote: > > Implement the --count-lines options for git stripspace [...] > > > > This will make it easier to port git-rebase--interactive.sh to C

Re: [PATCH v2 3/4] stripspace: Implement --count-lines option

Eric Sunshine writes: > With this in mind, my > question was also indirectly asking whether there was sufficient > justification of the long-term cost of a --count-lines option. The > argument that --count-lines would help test a proposed > strbuf_count_lines() likely

Re: [PATCH v2 3/4] stripspace: Implement --count-lines option

On Mon, Oct 19, 2015 at 1:03 PM, Christian Couder wrote: > On Mon, Oct 19, 2015 at 3:46 PM, Tobias Klauser wrote: >> On 2015-10-18 at 19:18:53 +0200, Junio C Hamano wrote: >>> Eric Sunshine writes: >>>

Re: [PATCH v2 3/4] stripspace: Implement --count-lines option

On Mon, Oct 19, 2015 at 3:46 PM, Tobias Klauser wrote: > On 2015-10-18 at 19:18:53 +0200, Junio C Hamano wrote: >> Eric Sunshine writes: >> >> > Is there any application beyond git-rebase--interactive where a >> > --count-lines

Re: [PATCH v2 3/4] stripspace: Implement --count-lines option

Eric Sunshine writes: > Is there any application beyond git-rebase--interactive where a > --count-lines options is expected to be useful? It's not obvious from > the commit message that this change is necessarily a win for later > porting of git-rebase--interactive to C

Re: [PATCH v2 3/4] stripspace: Implement --count-lines option

On Fri, Oct 16, 2015 at 11:16 AM, Tobias Klauser wrote: > Implement the --count-lines options for git stripspace [...] > > This will make it easier to port git-rebase--interactive.sh to C later > on. Is there any application beyond git-rebase--interactive where a

[PATCH v2 3/4] stripspace: Implement --count-lines option

Implement the --count-lines options for git stripspace to be able to omit calling: git stripspace --strip-comments < infile | wc -l e.g. in git-rebase--interactive.sh. The above command can now be replaced by: git stripspace --strip-comments --count-lines < infile This will make it easier