Re: [PATCH v2 3/9] t3701: use test_write_lines and write_script

2018-02-21 Thread Phillip Wood
On 20/02/18 17:19, Junio C Hamano wrote: Eric Sunshine writes: test_expect_success 'setup fake editor' ' - echo "#!$SHELL_PATH" >fake_editor.sh && - cat >>fake_editor.sh <<-\EOF && + FAKE_EDITOR="$(pwd)/fake-editor.sh" && + write_script

Re: [PATCH v2 3/9] t3701: use test_write_lines and write_script

2018-02-20 Thread Junio C Hamano
Eric Sunshine writes: >> test_expect_success 'setup fake editor' ' >> - echo "#!$SHELL_PATH" >fake_editor.sh && >> - cat >>fake_editor.sh <<-\EOF && >> + FAKE_EDITOR="$(pwd)/fake-editor.sh" && >> + write_script "$FAKE_EDITOR" <<-\EOF && >>

Re: [PATCH v2 3/9] t3701: use test_write_lines and write_script

2018-02-19 Thread Eric Sunshine
On Mon, Feb 19, 2018 at 6:29 AM, Phillip Wood wrote: > From: Phillip Wood > > Simplify things slightly by using the above helpers. > > Signed-off-by: Phillip Wood > --- > diff --git a/t/t3701-add-interactive.sh

[PATCH v2 3/9] t3701: use test_write_lines and write_script

2018-02-19 Thread Phillip Wood
From: Phillip Wood Simplify things slightly by using the above helpers. Signed-off-by: Phillip Wood --- t/t3701-add-interactive.sh | 36 +++- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git