Re: [PATCH v2 4/4] sequencer: don't die() on bogus user-edited timestamp

2018-07-31 Thread Eric Sunshine
On Tue, Jul 31, 2018 at 6:02 AM Phillip Wood wrote: > On 31/07/18 08:33, Eric Sunshine wrote: > > + /* validate date since fmt_ident() will die() on bad value */ > > + if (parse_date(val[2], )){ > > + warning(_("invalid date format '%s' in '%s'"), > > +

Re: [PATCH v2 4/4] sequencer: don't die() on bogus user-edited timestamp

2018-07-31 Thread Phillip Wood
On 31/07/18 08:33, Eric Sunshine wrote: read_author_ident() is careful to handle errors "gently" when parsing "rebase-merge/author-script" by printing a suitable warning and returning NULL; it never die()'s. One possible reason that parsing might fail is that "rebase-merge/author-script" has

[PATCH v2 4/4] sequencer: don't die() on bogus user-edited timestamp

2018-07-31 Thread Eric Sunshine
read_author_ident() is careful to handle errors "gently" when parsing "rebase-merge/author-script" by printing a suitable warning and returning NULL; it never die()'s. One possible reason that parsing might fail is that "rebase-merge/author-script" has been hand-edited in such a way which corrupts