Re: [PATCH v2 4/4] t4059: rewrite to be adaptive to hunk filtering

2015-04-13 Thread Max Kirillov
On Sat, Apr 11, 2015 at 10:48:22PM -0700, Junio C Hamano wrote: Max Kirillov m...@max630.net writes: Rather, it should verify that file selection behaves the same as hunk selection. Hrm, really? git diff --raw and git diff -p -w on two trees would not show identical set of paths, when the

Re: [PATCH v2 4/4] t4059: rewrite to be adaptive to hunk filtering

2015-04-11 Thread Junio C Hamano
Max Kirillov m...@max630.net writes: Looks like there is no exact specification what `diff -c` and `diff --cc` should output. Considering this it is not reasonable to hardcode any specific output in test. OK. Rather, it should verify that file selection behaves the same as hunk selection.

[PATCH v2 4/4] t4059: rewrite to be adaptive to hunk filtering

2015-04-03 Thread Max Kirillov
Looks like there is no exact specification what `diff -c` and `diff --cc` should output. Considering this it is not reasonable to hardcode any specific output in test. Rather, it should verify that file selection behaves the same as hunk selection. Rewrite test so that it makes sure that a short