Re: [PATCH v2 4/8] refs: factor delete_ref loose ref step into a helper

On 08/31/2013 12:30 PM, Michael Haggerty wrote: Given that ret is only returned, you could restore the filename before the if statement and replace the ret variable with an immediate return statement: Good idea. Fixed in next revision. Thanks, -Brad -- To unsubscribe from this list: send the

Re: [PATCH v2 4/8] refs: factor delete_ref loose ref step into a helper

On 08/30/2013 08:12 PM, Brad King wrote: Factor loose ref deletion into helper function delete_ref_loose to allow later use elsewhere. Signed-off-by: Brad King brad.k...@kitware.com --- refs.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

[PATCH v2 4/8] refs: factor delete_ref loose ref step into a helper

Factor loose ref deletion into helper function delete_ref_loose to allow later use elsewhere. Signed-off-by: Brad King brad.k...@kitware.com --- refs.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/refs.c b/refs.c index 2e755b4..5dd86ee 100644 ---