Re: [PATCH v2 5/5] remote-curl: use post_rpc() for protocol v2 also

2019-02-25 Thread Jeff King
On Thu, Feb 21, 2019 at 12:24:41PM -0800, Jonathan Tan wrote: > When transmitting and receiving POSTs for protocol v0 and v1, > remote-curl uses post_rpc() (and associated functions), but when doing > the same for protocol v2, it uses a separate set of functions > (proxy_rpc() and others). Besides

Re: [PATCH v2 5/5] remote-curl: use post_rpc() for protocol v2 also

2019-02-22 Thread Eric Sunshine
On Fri, Feb 22, 2019 at 8:18 AM Eric Sunshine wrote: > On Thu, Feb 21, 2019 at 3:25 PM Jonathan Tan wrote: > > + for i in $(test_seq 1 1500) > > + do > > + # do not use here-doc, because it requires a process > > + # per loop iteration > > + e

Re: [PATCH v2 5/5] remote-curl: use post_rpc() for protocol v2 also

2019-02-22 Thread Eric Sunshine
On Thu, Feb 21, 2019 at 3:25 PM Jonathan Tan wrote: > diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh > @@ -542,7 +542,38 @@ test_expect_success 'clone with http:// using protocol > v2' ' > +test_expect_success 'clone big repository with http:// using protocol v2' ' > + test_wh

[PATCH v2 5/5] remote-curl: use post_rpc() for protocol v2 also

2019-02-21 Thread Jonathan Tan
When transmitting and receiving POSTs for protocol v0 and v1, remote-curl uses post_rpc() (and associated functions), but when doing the same for protocol v2, it uses a separate set of functions (proxy_rpc() and others). Besides duplication of code, this has caused at least one bug: the auth retry