[PATCH v2 5/6] completion: refactor __gitcomp related tests

2012-11-11 Thread Felipe Contreras
Lots of duplicated code! No functional changes. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 76 ++- 1 file changed, 27 insertions(+), 49 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 59cdbfd..66c7af

Re: [PATCH v2 5/6] completion: refactor __gitcomp related tests

2012-11-16 Thread Junio C Hamano
Not asking for a re-roll but am asking for clarification so that I can locally update before queuing. Felipe Contreras writes: > Lots of duplicated code! ... removed, you mean? > No functional changes. > > Signed-off-by: Felipe Contreras > --- > t/t9902-completion.sh | 76 >

Re: [PATCH v2 5/6] completion: refactor __gitcomp related tests

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 8:13 PM, Junio C Hamano wrote: > Not asking for a re-roll but am asking for clarification so that I > can locally update before queuing. > > Felipe Contreras writes: > >> Lots of duplicated code! > > ... removed, you mean? Yes. >> No functional changes. >> >> Signed-off-

Re: [PATCH v2 5/6] completion: refactor __gitcomp related tests

2012-11-16 Thread SZEDER Gábor
On Sun, Nov 11, 2012 at 03:35:57PM +0100, Felipe Contreras wrote: > Lots of duplicated code! > > No functional changes. > > Signed-off-by: Felipe Contreras > --- > t/t9902-completion.sh | 76 > ++- > 1 file changed, 27 insertions(+), 49 deletions

Re: [PATCH v2 5/6] completion: refactor __gitcomp related tests

2012-11-16 Thread Junio C Hamano
SZEDER Gábor writes: > On Sun, Nov 11, 2012 at 03:35:57PM +0100, Felipe Contreras wrote: >> Lots of duplicated code! >> >> No functional changes. >> >> Signed-off-by: Felipe Contreras >> --- >> t/t9902-completion.sh | 76 >> ++- >> 1 file chang