Re: [PATCH v2 54/94] builtin/apply: make parse_chunk() return a negative integer on error

2016-06-08 Thread Christian Couder
On Mon, May 16, 2016 at 5:04 AM, Eric Sunshine wrote: > On Wed, May 11, 2016 at 9:17 AM, Christian Couder > wrote: >> To libify `git apply` functionality we have to signal errors to the >> caller instead of die()ing or exit()ing. >> >> To do

Re: [PATCH v2 54/94] builtin/apply: make parse_chunk() return a negative integer on error

2016-05-16 Thread Christian Couder
On Mon, May 16, 2016 at 5:04 AM, Eric Sunshine wrote: > On Wed, May 11, 2016 at 9:17 AM, Christian Couder > wrote: >> To libify `git apply` functionality we have to signal errors to the >> caller instead of die()ing or exit()ing. >> >> To do

Re: [PATCH v2 54/94] builtin/apply: make parse_chunk() return a negative integer on error

2016-05-15 Thread Eric Sunshine
On Wed, May 11, 2016 at 9:17 AM, Christian Couder wrote: > To libify `git apply` functionality we have to signal errors to the > caller instead of die()ing or exit()ing. > > To do that in a compatible manner with the rest of the error handling > in builtin/apply.c,

[PATCH v2 54/94] builtin/apply: make parse_chunk() return a negative integer on error

2016-05-11 Thread Christian Couder
To libify `git apply` functionality we have to signal errors to the caller instead of die()ing or exit()ing. To do that in a compatible manner with the rest of the error handling in builtin/apply.c, find_header() should return -1 instead of calling die() or exit(). As parse_chunk() is called