On Wed, Sep 19, 2018 at 5:50 AM Eric Sunshine wrote:
>
> If so, then please use test_cmp() rather than raw 'cmp' since
> test_cmp() will show the actual difference between the expected and
> actual files, which can be helpful when diagnosing a failing test.
>
All the other testcases in this file
On Tue, Sep 18, 2018 at 10:56 PM Matthew DeVore wrote:
> On Mon, Sep 17, 2018 at 6:57 PM Eric Sunshine wrote:
> > On Mon, Sep 17, 2018 at 6:25 PM Matthew DeVore wrote:
> > > + cmp - $3
> >
> > This is just wrong. The "-" argument to 'cmp' says to read from
> > standard input, but
On Mon, Sep 17, 2018 at 6:57 PM Eric Sunshine wrote:
>
> On Mon, Sep 17, 2018 at 6:25 PM Matthew DeVore wrote:
> > t9109-git-svn-props.sh: split up several pipes
>
> Similar to my comment about 5/6, this title talks about the mechanical
> changes made by the patch but not the intent. Perhaps
On Mon, Sep 17, 2018 at 6:25 PM Matthew DeVore wrote:
> t9109-git-svn-props.sh: split up several pipes
Similar to my comment about 5/6, this title talks about the mechanical
changes made by the patch but not the intent. Perhaps reword it like
this:
t9109: avoid swallowing Git exit code
A test uses several separate pipe sequences in a row which are awkward
to split up. Wrap the split-up pipe in a function so the awkwardness is
not repeated.
Signed-off-by: Matthew DeVore
---
t/t9101-git-svn-props.sh | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
5 matches
Mail list logo