Re: [PATCH v2 6/6] worktree: simplify prefixing paths

2016-05-23 Thread Duy Nguyen
On Mon, May 23, 2016 at 11:31 AM, Eric Sunshine wrote: > On Sun, May 22, 2016 at 7:32 PM, Eric Sunshine > wrote: >> On Sun, May 22, 2016 at 5:33 AM, Nguyễn Thái Ngọc Duy >> wrote: >>> @@ -467,6 +467,8 @@ int cmd_worktree(int

Re: [PATCH v2 6/6] worktree: simplify prefixing paths

2016-05-22 Thread Eric Sunshine
On Sun, May 22, 2016 at 7:32 PM, Eric Sunshine wrote: > On Sun, May 22, 2016 at 5:33 AM, Nguyễn Thái Ngọc Duy > wrote: >> @@ -467,6 +467,8 @@ int cmd_worktree(int ac, const char **av, const char >> *prefix) >> if (ac < 2) >>

Re: [PATCH v2 6/6] worktree: simplify prefixing paths

2016-05-22 Thread Eric Sunshine
On Sun, May 22, 2016 at 5:33 AM, Nguyễn Thái Ngọc Duy wrote: > This also makes slash conversion always happen on Windows (a side effect > of prefix_filename). Which is a good thing. Selling this patch as a mere simplification seems misguided (especially as it's subjective

[PATCH v2 6/6] worktree: simplify prefixing paths

2016-05-22 Thread Nguyễn Thái Ngọc Duy
This also makes slash conversion always happen on Windows (a side effect of prefix_filename). Which is a good thing. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/worktree.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/builtin/worktree.c