Re: [PATCH v2 6/7] reflog-walk: stop using fake parents

On Fri, Jul 07, 2017 at 11:54:05AM -0400, Kyle Meyer wrote: > Jeff King writes: > > > Prior to this commit, we show both entries with > > identical reflog messages. After this commit, we show > > only the "comes back" entry. See the update in t3200 > > which

Re: [PATCH v2 6/7] reflog-walk: stop using fake parents

Jeff King writes: > Prior to this commit, we show both entries with > identical reflog messages. After this commit, we show > only the "comes back" entry. See the update in t3200 > which demonstrates this. > > Arguably either is fine, as the whole

Re: [PATCH v2 6/7] reflog-walk: stop using fake parents

On Fri, Jul 07, 2017 at 05:14:07AM -0400, Jeff King wrote: > @@ -3132,7 +3132,10 @@ static struct commit *get_revision_1(struct rev_info > *revs) > if (revs->max_age != -1 && > (commit->date < revs->max_age)) >

[PATCH v2 6/7] reflog-walk: stop using fake parents

The reflog-walk system works by putting a ref's tip into the pending queue, and then "traversing" the reflog by pretending that the parent of each commit is the previous reflog entry. This causes a number of user-visible oddities, as documented in t1414 (and the commit message which introduced