Re: [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package

2017-12-19 Thread SZEDER Gábor
On Mon, Dec 18, 2017 at 11:04 PM, SZEDER Gábor wrote: > $ sudo apt-get install language-pack-is > [...] > $ ./t0204-gettext-reencode-sanity.sh > # lib-gettext: Found 'is_IS.utf8' as an is_IS UTF-8 locale > # lib-gettext: No is_IS ISO-8859-1 locale available > ok 1 - gettext: Emitting

Re: [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package

2017-12-18 Thread Junio C Hamano
Lars Schneider writes: >> It seems we would loose coverage with this patch, so it should be >> dropped. > > Yeah. I think we should add a comment to the travis.yml to avoid > future confusion. I'll do it unless you beat me to it with a re-roll. Rather, it should be commented close to where is lo

Re: [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package

2017-12-18 Thread Lars Schneider
> On 18 Dec 2017, at 23:04, SZEDER Gábor wrote: > > On Mon, Dec 18, 2017 at 10:33 PM, Lars Schneider > wrote: >> >>> On 16 Dec 2017, at 13:57, SZEDER Gábor wrote: >>> >>> Ever since we have started to use Travis CI in 522354d70 (Add Travis >>> CI support, 2015-11-27), our 64 bit Linux build

Re: [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package

2017-12-18 Thread SZEDER Gábor
On Mon, Dec 18, 2017 at 10:33 PM, Lars Schneider wrote: > >> On 16 Dec 2017, at 13:57, SZEDER Gábor wrote: >> >> Ever since we have started to use Travis CI in 522354d70 (Add Travis >> CI support, 2015-11-27), our 64 bit Linux build jobs install the >> 'languate-pack-is' package. That commit doe

Re: [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package

2017-12-18 Thread Lars Schneider
> On 16 Dec 2017, at 13:57, SZEDER Gábor wrote: > > Ever since we have started to use Travis CI in 522354d70 (Add Travis > CI support, 2015-11-27), our 64 bit Linux build jobs install the > 'languate-pack-is' package. That commit doesn't discuss why it was > deemed necessary back then, but Trav

[PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package

2017-12-16 Thread SZEDER Gábor
Ever since we have started to use Travis CI in 522354d70 (Add Travis CI support, 2015-11-27), our 64 bit Linux build jobs install the 'languate-pack-is' package. That commit doesn't discuss why it was deemed necessary back then, but Travis CI can build and test Git without that package just fine,