Re: [PATCH v2 63/94] builtin/apply: make apply_all_patches() return -1 on error

On Wed, Jun 8, 2016 at 7:44 PM, Eric Sunshine wrote: > On Wed, Jun 8, 2016 at 12:37 PM, Christian Couder > wrote: >> On Mon, May 16, 2016 at 5:44 AM, Eric Sunshine >> wrote: >>> On Wed, May 11, 2016 at 9:17 AM,

Re: [PATCH v2 63/94] builtin/apply: make apply_all_patches() return -1 on error

On Wed, Jun 8, 2016 at 12:37 PM, Christian Couder wrote: > On Mon, May 16, 2016 at 5:44 AM, Eric Sunshine > wrote: >> On Wed, May 11, 2016 at 9:17 AM, Christian Couder >> wrote: >>> if

Re: [PATCH v2 63/94] builtin/apply: make apply_all_patches() return -1 on error

On Mon, May 16, 2016 at 5:44 AM, Eric Sunshine wrote: > On Wed, May 11, 2016 at 9:17 AM, Christian Couder > wrote: >> To finish libifying the apply functionality, apply_all_patches() should not >> die() or exit() in case of error, but return

Re: [PATCH v2 63/94] builtin/apply: make apply_all_patches() return -1 on error

On Wed, May 11, 2016 at 9:17 AM, Christian Couder wrote: > To finish libifying the apply functionality, apply_all_patches() should not > die() or exit() in case of error, but return -1. > > While doing that we must take care that file descriptors are properly closed >

[PATCH v2 63/94] builtin/apply: make apply_all_patches() return -1 on error

To finish libifying the apply functionality, apply_all_patches() should not die() or exit() in case of error, but return -1. While doing that we must take care that file descriptors are properly closed and, if needed, reset a sensible value. Helped-by: Nguyễn Thái Ngọc Duy