Re: [PATCH v2 7/9] connect: tell server that the client understands v1

2017-09-29 Thread Brandon Williams
On 09/27, Junio C Hamano wrote: > Junio C Hamano writes: > > >> + # Client requested to use protocol v1 > >> + grep "version=1" log && > >> + # Server responded using protocol v1 > >> + grep "clone< version 1" log > > > > This looked a bit strange to check "clone< version

Re: [PATCH v2 7/9] connect: tell server that the client understands v1

2017-09-28 Thread Brandon Williams
On 09/27, Junio C Hamano wrote: > Brandon Williams writes: > > > Teach the connection logic to tell a serve that it understands protocol > > v1. This is done in 2 different ways for the built in protocols. > > > > 1. git:// > >A normal request is structured as "command

Re: [PATCH v2 7/9] connect: tell server that the client understands v1

2017-09-27 Thread Junio C Hamano
Junio C Hamano writes: >> +# Client requested to use protocol v1 >> +grep "version=1" log && >> +# Server responded using protocol v1 >> +grep "clone< version 1" log > > This looked a bit strange to check "clone< version 1" for one > direction, but did not

Re: [PATCH v2 7/9] connect: tell server that the client understands v1

2017-09-27 Thread Junio C Hamano
Brandon Williams writes: > Teach the connection logic to tell a serve that it understands protocol > v1. This is done in 2 different ways for the built in protocols. > > 1. git:// >A normal request is structured as "command path/to/repo\0host=..\0" >and due to a bug

[PATCH v2 7/9] connect: tell server that the client understands v1

2017-09-26 Thread Brandon Williams
Teach the connection logic to tell a serve that it understands protocol v1. This is done in 2 different ways for the built in protocols. 1. git:// A normal request is structured as "command path/to/repo\0host=..\0" and due to a bug in an old version of git-daemon 73bb33a94 (daemon: