Liam Beguin writes:
> Since this came up, would it be a good thing to add -Wignored-qualifiers
> to the DEVELOPER flags?
Quite frankly, I am not sure if catching that particular warning
violation buys us much. As a return value from a function is never
an lvalue, what triggers the warning may ce
Hi Junio,
On 27 December 2017 at 20:15, Junio C Hamano wrote:
> Duy Nguyen writes:
>
>> On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote:
>>> +static const char command_to_char(const enum todo_command command)
>>> +{
>>> + if (command < TODO_COMMENT && todo_command_info[command].c)
>>>
Duy Nguyen writes:
> On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote:
>> +static const char command_to_char(const enum todo_command command)
>> +{
>> + if (command < TODO_COMMENT && todo_command_info[command].c)
>> + return todo_command_info[command].c;
>> + return co
On Mon, Dec 25, 2017 at 10:39 PM, Liam Beguin wrote:
> I'm curious, how did you build to get this error to show?
> I tried with the DEVELOPER 'flag' but nothing showed and -Wextra gave
> way too much messages...
> Did you just add -Wignored-qualifiers to CFLAGS?
I have a custom CFLAGS, created be
Hi Duy,
On Mon, 25 Dec 2017 at 07:48 Duy Nguyen wrote:
>
> On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote:
> > +static const char command_to_char(const enum todo_command command)
> > +{
> > + if (command < TODO_COMMENT && todo_command_info[command].c)
> > + return todo_com
On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote:
> +static const char command_to_char(const enum todo_command command)
> +{
> + if (command < TODO_COMMENT && todo_command_info[command].c)
> + return todo_command_info[command].c;
> + return comment_line_char;
> +}
C
`git rebase -i` already know how to interpret single-letter command
names. Teach it to generate the todo list with these same abbreviated
names.
Based-on-patch-by: Johannes Schindelin
Signed-off-by: Liam Beguin
---
Documentation/rebase-config.txt | 20
builtin/rebase--helpe
7 matches
Mail list logo