Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-14 Thread brian m. carlson
On Wed, Jul 11, 2018 at 12:38:24PM +0200, Henning Schild wrote: > Am Tue, 10 Jul 2018 13:09:01 -0400 > schrieb Jeff King : > > > On Tue, Jul 10, 2018 at 10:52:31AM +0200, Henning Schild wrote: > > > > > diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh > > > index a5d3b2cba..9dcb4e990 100755 > > > ---

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Henning Schild
Am Wed, 11 Jul 2018 10:33:52 -0400 schrieb Jeff King : > On Tue, Jul 10, 2018 at 10:52:31AM +0200, Henning Schild wrote: > > > diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh > > index a5d3b2cba..9dcb4e990 100755 > > --- a/t/lib-gpg.sh > > +++ b/t/lib-gpg.sh > > @@ -38,7 +38,14 @@ then > >

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Junio C Hamano
Jeff King writes: >> While addressing 1 make 2 obvious and worse, addressing 2 is a whole >> different story and should probably be discussed outside of this >> thread. And i would not like to inherit responsibility for 2. In >> fact the whole discussion emphasizes that it was a good idea to

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Henning Schild
Am Wed, 11 Jul 2018 10:35:54 -0400 schrieb Jeff King : > On Wed, Jul 11, 2018 at 03:40:19PM +0200, Henning Schild wrote: > > > > So it may be simplest to just run most of the tests twice, once > > > with gpg and once with gpgsm. I kind of wonder if all of t7510 > > > could just be bumped into a

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Jeff King
On Wed, Jul 11, 2018 at 03:40:19PM +0200, Henning Schild wrote: > > So it may be simplest to just run most of the tests twice, once with > > gpg and once with gpgsm. I kind of wonder if all of t7510 could just > > be bumped into a function. Or even into a sourced file and run from > > two

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Jeff King
On Tue, Jul 10, 2018 at 10:52:31AM +0200, Henning Schild wrote: > diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh > index a5d3b2cba..9dcb4e990 100755 > --- a/t/lib-gpg.sh > +++ b/t/lib-gpg.sh > @@ -38,7 +38,14 @@ then > "$TEST_DIRECTORY"/lib-gpg/ownertrust && > gpg

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Henning Schild
Am Wed, 11 Jul 2018 08:51:10 -0400 schrieb Jeff King : > On Wed, Jul 11, 2018 at 12:38:24PM +0200, Henning Schild wrote: > > > > Can we save a dummy generated key and just import it? That's what > > > we do for the regular gpg case. > > > > I will look into storing a binary and leaving notes

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Jeff King
On Wed, Jul 11, 2018 at 12:38:24PM +0200, Henning Schild wrote: > > Can we save a dummy generated key and just import it? That's what we > > do for the regular gpg case. > > I will look into storing a binary and leaving notes how it was > generated, just like regular gpg does. The reason i did

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Henning Schild
Am Tue, 10 Jul 2018 14:12:57 -0700 schrieb Junio C Hamano : > Henning Schild writes: > > > Add test cases to cover the new X509/gpgsm support. Most of them > > resemble existing ones. They just switch the format to x509 and set > > the signingkey when creating signatures. Validation of

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-11 Thread Henning Schild
Am Tue, 10 Jul 2018 13:09:01 -0400 schrieb Jeff King : > On Tue, Jul 10, 2018 at 10:52:31AM +0200, Henning Schild wrote: > > > diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh > > index a5d3b2cba..9dcb4e990 100755 > > --- a/t/lib-gpg.sh > > +++ b/t/lib-gpg.sh > > @@ -38,7 +38,14 @@ then > >

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-10 Thread Junio C Hamano
Henning Schild writes: > Add test cases to cover the new X509/gpgsm support. Most of them > resemble existing ones. They just switch the format to x509 and set the > signingkey when creating signatures. Validation of signatures does not > need any configuration of git, it does need gpgsm to be

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 01:09:01PM -0400, Jeff King wrote: > > + gpgsm --homedir "${GNUPGHOME}" --import > > "$TEST_DIRECTORY"/lib-gpg/gpgsm.crt.user && > > + gpgsm --homedir "${GNUPGHOME}" -K | grep fingerprint: | cut -d" > > " -f4 | tr -d '\n' > ${GNUPGHOME}/trustlist.txt

Re: [PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 10:52:31AM +0200, Henning Schild wrote: > diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh > index a5d3b2cba..9dcb4e990 100755 > --- a/t/lib-gpg.sh > +++ b/t/lib-gpg.sh > @@ -38,7 +38,14 @@ then > "$TEST_DIRECTORY"/lib-gpg/ownertrust && > gpg

[PATCH v2 9/9] gpg-interface t: extend the existing GPG tests with GPGSM

2018-07-10 Thread Henning Schild
Add test cases to cover the new X509/gpgsm support. Most of them resemble existing ones. They just switch the format to x509 and set the signingkey when creating signatures. Validation of signatures does not need any configuration of git, it does need gpgsm to be configured to trust the