Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-25 Thread Junio C Hamano
Jonathan Nieder writes: > The patch "fix handling of badly named refs"[1] is still undergoing > heavy churn. > > I think it's worth getting that one right. Oh, no question about it. I was only making sure that I didn't miss availability of updates for larger series we saw during this cycle. --

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-25 Thread Jonathan Nieder
Junio C Hamano wrote: > I know that a review-update cycle is still going in the dark at > > https://code-review.googlesource.com/#/q/topic:ref-transaction > > for this series. Eh, it's at least public and doesn't flood the list with rebased versions of the series. Would you prefer if there wer

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-25 Thread Junio C Hamano
I know that a review-update cycle is still going in the dark at https://code-review.googlesource.com/#/q/topic:ref-transaction for this series. Are we almost there for v22 which hopefully be the final before we merge it to 'next' and go incremental? -- To unsubscribe from this list: send the

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-18 Thread Jonathan Nieder
Junio C Hamano wrote: > Does the order of changes that appear in > > https://code-review.googlesource.com/#/q/project:git+branch:master+topic:ref-transaction > > have any significance? e.g. is a "topic" supposed to be a single > strand of pearls on top of the "branch", and the top one is the tip,

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-18 Thread Junio C Hamano
Jonathan Nieder writes: > Junio C Hamano wrote: > >> Jonathan: Is a current version of this patch series set up to be >> fetched so that it can be reviewed outside Gerrit? > > The current tip is 06d707cb63e34fc55a18ecc47e668f3c44acae57 from > https://code.googlesource.com/git (fetch-by-sha1 shoul

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-18 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan: Is a current version of this patch series set up to be > fetched so that it can be reviewed outside Gerrit? The current tip is 06d707cb63e34fc55a18ecc47e668f3c44acae57 from https://code.googlesource.com/git (fetch-by-sha1 should work). Each reroll gets its own r

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-18 Thread Junio C Hamano
Michael Haggerty writes: > On 09/13/2014 01:57 AM, Jonathan Nieder wrote: >> Michael Haggerty wrote: Jonathan Nieder writes: >> > so I'll send a reroll of the series as-is in an hour or so. >>> >>> Jonathan: Is a current version of this patch series set up for review in >>> Gerrit? >>

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-17 Thread Michael Haggerty
On 09/13/2014 01:57 AM, Jonathan Nieder wrote: > Michael Haggerty wrote: >>> Jonathan Nieder writes: > so I'll send a reroll of the series as-is in an hour or so. >> >> Jonathan: Is a current version of this patch series set up for review in >> Gerrit? > > Yes. > (https://code-review.google

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-13 Thread Junio C Hamano
Junio C Hamano writes: > I noticed that with this series merged to the version I use daily, > detaching HEAD (i.e. "git checkout HEAD^0") breaks my HEAD reflog, > which made me redo the integration ejecting the series out of 'pu'. > > Not happy, as my workflow relies fairly heavily on detached HE

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-12 Thread Jonathan Nieder
Michael Haggerty wrote: >> Jonathan Nieder writes: >>> so I'll send a reroll of the series as-is in an hour or so. > > Jonathan: Is a current version of this patch series set up for review in > Gerrit? Yes. (https://code-review.googlesource.com/#/q/project:git+topic:ref-transaction) Thanks, Jon

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-12 Thread Michael Haggerty
On 09/12/2014 09:56 PM, Junio C Hamano wrote: > Jonathan Nieder writes: > [...] >> There were a few other minor changes, and I think with them the series >> should be ready for "next". My "send and hope that more reviewers >> appear" strategy didn't really work,... > > You sent them just a few d

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-12 Thread Junio C Hamano
Junio C Hamano writes: > Jonathan Nieder writes: > >> It's "Oops, the next one (refs.c: do not permit err == NULL) is broken, >> and this is to patch it up in advance". :) >> >> But it should apply on top, too. > > I think "in advance" makes sense for this one, too. > >> There were a few other m

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-12 Thread Junio C Hamano
Jonathan Nieder writes: > It's "Oops, the next one (refs.c: do not permit err == NULL) is broken, > and this is to patch it up in advance". :) > > But it should apply on top, too. I think "in advance" makes sense for this one, too. > There were a few other minor changes, and I think with them t

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-12 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: > > Junio C Hamano wrote: >>> The tag fetched and built as-is seems to break 5514 among other >>> things ("git remote rm" segfaults). >> >> Yeah, I noticed that right after sending the series out. :/ >> >> The patch below fixes it[1]. > > Is this me

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-12 Thread Junio C Hamano
Jonathan Nieder writes: > Junio C Hamano wrote: >> Jonathan Nieder writes: > >>> These patches are also available from the git repository at >>> >>> git://repo.or.cz/git/jrn.git tags/rs/ref-transaction >> >> The tag fetched and built as-is seems to break 5514 among other >> things ("git remote

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-11 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >> These patches are also available from the git repository at >> >> git://repo.or.cz/git/jrn.git tags/rs/ref-transaction > > The tag fetched and built as-is seems to break 5514 among other > things ("git remote rm" segfaults). Yeah, I noticed th

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-11 Thread Junio C Hamano
Jonathan Nieder writes: > These patches are also available from the git repository at > > git://repo.or.cz/git/jrn.git tags/rs/ref-transaction The tag fetched and built as-is seems to break 5514 among other things ("git remote rm" segfaults). -- To unsubscribe from this list: send the line "un

Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-11 Thread Junio C Hamano
Jonathan Nieder writes: > Jonathan Nieder wrote: > >> The next series from Ronnie's collection is available at >> https://code-review.googlesource.com/#/q/topic:ref-transaction in case >> someone wants a fresh series to look at. > > Here is the outcome of that review. It could use another set of

[PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview)

2014-09-10 Thread Jonathan Nieder
Jonathan Nieder wrote: > The next series from Ronnie's collection is available at > https://code-review.googlesource.com/#/q/topic:ref-transaction in case > someone wants a fresh series to look at. Here is the outcome of that review. It could use another set of eyes (hint, hint) but should be mo