Re: [PATCH v3] Replace memcpy with hashcpy when dealing hash copy globally

2014-03-05 Thread Junio C Hamano
Sun He sunheeh...@gmail.com writes: Replacing memcpy with hashcpy is more directly and elegant. Can we justify the change without being subjective? Leave ppc/sha1.c alone, as it is an isolated component. Pull cache.h(actually ../cache.h) in just for one memcpy there is not proper. That is

[PATCH v3] Replace memcpy with hashcpy when dealing hash copy globally

2014-03-03 Thread Sun He
Replacing memcpy with hashcpy is more directly and elegant. Leave ppc/sha1.c alone, as it is an isolated component. Pull cache.h(actually ../cache.h) in just for one memcpy there is not proper. Helped-by: Michael Haggerty mhag...@alum.mit.edu Helped-by: Duy Nguyen pclo...@gmail.com