On Thu, May 09, 2013 at 01:27:49PM -0700, Junio C Hamano gits...@pobox.com
wrote:
I'd apply this before -rc2. I _think_ it is also OK to just let
lookup_commit_reference_gently() barf with its standard message
error: Object %s is a %s, not a commit
without an extra
Miklos Vajna vmik...@suse.cz writes:
When a single argument was a non-commit, the error message used to be:
fatal: BUG: expected exactly one commit from walk
For multiple arguments, when none of the arguments was a commit, the error
was:
fatal: empty commit set passed
Junio C Hamano gits...@pobox.com writes:
Miklos Vajna vmik...@suse.cz writes:
When a single argument was a non-commit, the error message used to be:
fatal: BUG: expected exactly one commit from walk
For multiple arguments, when none of the arguments was a commit, the error
was:
On 04/15/2013 09:12 PM, Junio C Hamano wrote:
The paths given to handle_refs() may also have to be copied before
saved, depending on how ref iteration is implemented, details of
which may change as Michael seems to be updating the area again.
I think we let the callback peek ref_entry-name[]
Miklos Vajna vmik...@suse.cz writes:
Fix this bug and make sure all arguments are commits, and
for the first non-commit, error out with:
fatal: name: Can't cherry-pick a type
@@ -1067,6 +1068,23 @@ int sequencer_pick_revisions(struct replay_opts *opts)
if (opts-subcommand ==
Thomas Rast tr...@inf.ethz.ch writes:
From a cursory glance it looks like it's actually an existing bug in
read_revisions_from_stdin or handle_revision_arg, depending on which way
you look at it. read_revisions_from_stdin passes its temporary buffer
down to handle_revision_arg:
Thomas Rast tr...@inf.ethz.ch writes:
From a cursory glance it looks like it's actually an existing bug in
read_revisions_from_stdin or handle_revision_arg, depending on which way
you look at it. read_revisions_from_stdin passes its temporary buffer
down to handle_revision_arg:
When a single argument was a non-commit, the error message used to be:
fatal: BUG: expected exactly one commit from walk
For multiple arguments, when none of the arguments was a commit, the error was:
fatal: empty commit set passed
Finally, when some of the arguments were
Miklos Vajna wrote:
Signed-off-by: Miklos Vajna vmik...@suse.cz
This one looks good. FWIW,
Reviewed-by: Ramkumar Ramachandra artag...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at
9 matches
Mail list logo
