Re: [PATCH v3] commit.c: Replace starts_with() with skip_prefix()

Hey Eric, Its been nice learning from you about how to submit patches to git. was a nice learning curve, now I'm looking into the ideas and will contact the appropriate mentor soon with a plan. Thanks - Karthik On Sun, Mar 9, 2014 at 1:19 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On

Re: [PATCH v3] commit.c: Replace starts_with() with skip_prefix()

On Fri, Mar 7, 2014 at 5:49 AM, karthik nayak karthik@gmail.com wrote: Hello Eric, Thanks for your reply, and for that information. should i patch again or this should do? And what next? Talk to the mentor? The ultimate authority deciding if a patch is ready is Junio, as it would have to

Re: [PATCH v3] commit.c: Replace starts_with() with skip_prefix()

On Thu, Mar 6, 2014 at 12:05 PM, Karthik Nayak karthik@gmail.com wrote: Replace all instances of starts_with() by skip_prefix(), which can not only be used to check presence of a prefix, but also used further on as it returns the string after the prefix, if the prefix is present. And also

Re: [PATCH v3] commit.c: Replace starts_with() with skip_prefix()

Hello Eric, Thanks for your reply, and for that information. should i patch again or this should do? And what next? Talk to the mentor? Thanks -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v3] commit.c: Replace starts_with() with skip_prefix()

Replace all instances of starts_with() by skip_prefix(), which can not only be used to check presence of a prefix, but also used further on as it returns the string after the prefix, if the prefix is present. And also manages to do, what the current code does in two steps. Signed-off-by: Karthik

Re: [PATCH v3] commit.c: Replace starts_with() with skip_prefix()

We already have 147972b1 (commit.c: use skip_prefix() instead of starts_with(), 2014-03-04) that covers the record_author_date() and parse_gpg_output(), don't we? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v3] commit.c: Replace starts_with() with skip_prefix()

Karthik Nayak karthik@gmail.com writes: @@ -1098,6 +1099,7 @@ int parse_signed_commit(const unsigned char *sha1, char *buffer = read_sha1_file(sha1, type, size); int in_signature, saw_signature = -1; char *line, *tail; + const char *gpg_sig; if (!buffer ||