Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file

Eric Wong writes: > Andreas Heiduk wrote: >> Am 05.04.2018 um 09:51 schrieb Eric Wong: >> > Can you confirm it's OK for you? Thanks. >> >> Looks good, works for me. >> >> Do you squash this patch with with my commit or do you need a reroll? > > Nope, no

Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file

Andreas Heiduk wrote: > Am 05.04.2018 um 09:51 schrieb Eric Wong: > > Can you confirm it's OK for you? Thanks. > > Looks good, works for me. > > Do you squash this patch with with my commit or do you need a reroll? Nope, no need to reroll. Pushed to my repo for Junio.

Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file

Am 05.04.2018 um 09:51 schrieb Eric Wong: > Thanks for the update. The patch itself looks good, but I > noticed one --show-item isn't supported on SVN 1.8.10 for me. --show-item is indeed a 1.9.0 thing: https://subversion.apache.org/docs/release-notes/1.9.html#svn-info-item > I've tested the

Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file

Thanks for the update. The patch itself looks good, but I noticed one --show-item isn't supported on SVN 1.8.10 for me. I've tested the following on both SVN 1.8.10 and 1.9.5: --- a/t/t9138-git-svn-authors-prog.sh +++ b/t/t9138-git-svn-authors-prog.sh @@ -83,7 +83,8 @@ test_expect_success

[PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file

The email address in --authors-file and --authors-prog can be empty but git-svn translated it into a fictional email address in the form jondoe containing the SVN repository UUID. Now git-svn behaves like git-commit: If the email is *explicitly*