Re: [PATCH v3] handle lower case drive letters on Windows

2018-07-14 Thread Johannes Schindelin
Hi Junio, On Thu, 12 Jul 2018, Junio C Hamano wrote: > Ben Peart writes: > > >> > Thanks. I thought it was strange as well until I realized you only > >> > see the error message if there _isn't_ a valid drive letter so seeing > >> > the entire path makes sense as it will likely be something

Re: [PATCH v3] handle lower case drive letters on Windows

2018-07-12 Thread Junio C Hamano
Ben Peart writes: >> > Thanks. I thought it was strange as well until I realized you only >> > see the error message if there _isn't_ a valid drive letter so seeing >> > the entire path makes sense as it will likely be something like >> "\\server\volume\directory" >> >> Yup, that is why I

RE: [PATCH v3] handle lower case drive letters on Windows

2018-07-12 Thread Ben Peart
> > Thanks. I thought it was strange as well until I realized you only > > see the error message if there _isn't_ a valid drive letter so seeing > > the entire path makes sense as it will likely be something like > "\\server\volume\directory" > > Yup, that is why I thought Dscho meant to say

Re: [PATCH v3] handle lower case drive letters on Windows

2018-07-12 Thread Junio C Hamano
Ben Peart writes: >> -Original Message- >> From: Junio C Hamano On Behalf Of Junio C Hamano >> Sent: Thursday, July 12, 2018 3:13 PM >> To: Ben Peart >> Cc: git@vger.kernel.org; sbel...@google.com; johannes.schinde...@gmx.de >> Subject: Re: [PATCH

RE: [PATCH v3] handle lower case drive letters on Windows

2018-07-12 Thread Ben Peart
> -Original Message- > From: Junio C Hamano On Behalf Of Junio C Hamano > Sent: Thursday, July 12, 2018 3:13 PM > To: Ben Peart > Cc: git@vger.kernel.org; sbel...@google.com; johannes.schinde...@gmx.de > Subject: Re: [PATCH v3] handle lower case drive letters on Wind

Re: [PATCH v3] handle lower case drive letters on Windows

2018-07-12 Thread Junio C Hamano
Ben Peart writes: > On Windows, if a tool calls SetCurrentDirectory with a lower case drive > letter, the subsequent call to GetCurrentDirectory will return the same > lower case drive letter. Powershell, for example, does not normalize the > path. If that happens, test-drop-caches will error

[PATCH v3] handle lower case drive letters on Windows

2018-07-12 Thread Ben Peart
On Windows, if a tool calls SetCurrentDirectory with a lower case drive letter, the subsequent call to GetCurrentDirectory will return the same lower case drive letter. Powershell, for example, does not normalize the path. If that happens, test-drop-caches will error out as it does not correctly