Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-14 Thread Elia Pinto
2015-08-14 19:21 GMT+02:00 Junio C Hamano : > Torsten Bögershausen writes: > >>> diff --git a/Documentation/config.txt b/Documentation/config.txt >>> index 315f271..b23b01a 100644 >>> --- a/Documentation/config.txt >>> +++ b/Documentation/config.txt >>> @@ -1595,6 +1595,28 @@ http.saveCookies:: >>

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-14 Thread Junio C Hamano
Torsten Bögershausen writes: >> diff --git a/Documentation/config.txt b/Documentation/config.txt >> index 315f271..b23b01a 100644 >> --- a/Documentation/config.txt >> +++ b/Documentation/config.txt >> @@ -1595,6 +1595,28 @@ http.saveCookies:: >> If set, store cookies received during requests

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Eric Sunshine
On Thu, Aug 13, 2015 at 12:37 PM, Eric Sunshine wrote: > So, your loop can either look like this, if you use the NULL sentinel: > > struct ssl_map *p = sslversions; > while (p->name) { > if (!strcmp(ssl_version, p->name)) > ... > } That's not quite correct. 'p' nee

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Eric Sunshine
On Thu, Aug 13, 2015 at 12:15 PM, Elia Pinto wrote: > 2015-08-13 18:11 GMT+02:00 Eric Sunshine : >> On Thu, Aug 13, 2015 at 11:58 AM, Elia Pinto wrote: >>> 2015-08-13 17:47 GMT+02:00 Eric Sunshine : > + if (ssl_version != NULL && *ssl_version) { > + int i; > +

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Elia Pinto
2015-08-13 18:24 GMT+02:00 Ilari Liusvaara : > On Thu, Aug 13, 2015 at 06:10:48PM +0200, Elia Pinto wrote: >> 2015-08-13 18:01 GMT+02:00 Torsten Bögershausen : >> >> + >> > from >> > https://en.wikipedia.org/wiki/Transport_Layer_Security#SSL_1.0.2C_2.0_and_3.0 >> > sslv2 and sslv3 are deprecated. >

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Ilari Liusvaara
On Thu, Aug 13, 2015 at 06:10:48PM +0200, Elia Pinto wrote: > 2015-08-13 18:01 GMT+02:00 Torsten Bögershausen : > >> + > > from > > https://en.wikipedia.org/wiki/Transport_Layer_Security#SSL_1.0.2C_2.0_and_3.0 > > sslv2 and sslv3 are deprecated. > > Should there be a motivation in the commit messag

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Elia Pinto
2015-08-13 18:11 GMT+02:00 Eric Sunshine : > On Thu, Aug 13, 2015 at 11:58 AM, Elia Pinto wrote: >> 2015-08-13 17:47 GMT+02:00 Eric Sunshine : >>> On Thu, Aug 13, 2015 at 11:28 AM, Elia Pinto >>> wrote: Teach git about a new option, "http.sslVersion", which permits one to specify the S

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Eric Sunshine
On Thu, Aug 13, 2015 at 11:58 AM, Elia Pinto wrote: > 2015-08-13 17:47 GMT+02:00 Eric Sunshine : >> On Thu, Aug 13, 2015 at 11:28 AM, Elia Pinto wrote: >>> Teach git about a new option, "http.sslVersion", which permits one to >>> specify the SSL version to use when negotiating SSL connections.

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Elia Pinto
2015-08-13 18:01 GMT+02:00 Torsten Bögershausen : > (need to drop Eric from cc-list, no DNS from web.de) > > On 2015-08-13 17.28, Elia Pinto wrote: >> Teach git about a new option, "http.sslVersion", which permits one to >> specify the SSL version to use when negotiating SSL connections. The >> s

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Torsten Bögershausen
(need to drop Eric from cc-list, no DNS from web.de) On 2015-08-13 17.28, Elia Pinto wrote: > Teach git about a new option, "http.sslVersion", which permits one to > specify the SSL version to use when negotiating SSL connections. The > setting can be overridden by the GIT_SSL_VERSION environmen

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Elia Pinto
2015-08-13 17:47 GMT+02:00 Eric Sunshine : > On Thu, Aug 13, 2015 at 11:28 AM, Elia Pinto wrote: >> Teach git about a new option, "http.sslVersion", which permits one to >> specify the SSL version to use when negotiating SSL connections. The >> setting can be overridden by the GIT_SSL_VERSION en

Re: [PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Eric Sunshine
On Thu, Aug 13, 2015 at 11:28 AM, Elia Pinto wrote: > Teach git about a new option, "http.sslVersion", which permits one to > specify the SSL version to use when negotiating SSL connections. The > setting can be overridden by the GIT_SSL_VERSION environment > variable. > > Signed-off-by: Elia Pi

[PATCH v3] http: add support for specifying the SSL version

2015-08-13 Thread Elia Pinto
Teach git about a new option, "http.sslVersion", which permits one to specify the SSL version to use when negotiating SSL connections. The setting can be overridden by the GIT_SSL_VERSION environment variable. Signed-off-by: Elia Pinto --- This is the third version of the patch. The changes com