Re: [PATCH v3] index-pack: add ability to disable SHA-1 collision check

2018-11-14 Thread Ævar Arnfjörð Bjarmason
On Wed, Nov 14 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Add a new core.checkCollisions setting. On by default, it can be set >> to 'false' to disable the check for existing objects in sha1_object(). >> ... >> diff --git a/builtin/index-pack.c b/builtin/index-pack.c

Re: [PATCH v3] index-pack: add ability to disable SHA-1 collision check

2018-11-13 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Add a new core.checkCollisions setting. On by default, it can be set > to 'false' to disable the check for existing objects in sha1_object(). > ... > diff --git a/builtin/index-pack.c b/builtin/index-pack.c > index 2004e25da2..4a3508aa9f 100644 > ---

[PATCH v3] index-pack: add ability to disable SHA-1 collision check

2018-11-13 Thread Ævar Arnfjörð Bjarmason
Add a new core.checkCollisions setting. On by default, it can be set to 'false' to disable the check for existing objects in sha1_object(). As noted in the documentation being added here this is done out of paranoia about future SHA-1 collisions and as a canary (redundant to "git fsck") for local