Re: [PATCH v3] parse-remote: remove reference to unused op_prep

2017-02-06 Thread Junio C Hamano
Siddharth Kannan writes: > Hey Pranit, > On Sun, Feb 05, 2017 at 02:45:46AM +0530, Pranit Bauva wrote: >> Hey Siddharth, >> >> On Sat, Feb 4, 2017 at 8:01 PM, Siddharth Kannan >> wrote: >> > The error_on_missing_default_upstream helper function learned to >> > take op_prep argument with 15a147e

Re: [PATCH v3] parse-remote: remove reference to unused op_prep

2017-02-05 Thread Siddharth Kannan
Hey Pranit, On Sun, Feb 05, 2017 at 02:45:46AM +0530, Pranit Bauva wrote: > Hey Siddharth, > > On Sat, Feb 4, 2017 at 8:01 PM, Siddharth Kannan > wrote: > > The error_on_missing_default_upstream helper function learned to > > take op_prep argument with 15a147e618 ("rebase: use @{upstream} > > if

Re: [PATCH v3] parse-remote: remove reference to unused op_prep

2017-02-04 Thread Pranit Bauva
Hey Siddharth, On Sat, Feb 4, 2017 at 8:01 PM, Siddharth Kannan wrote: > The error_on_missing_default_upstream helper function learned to > take op_prep argument with 15a147e618 ("rebase: use @{upstream} > if no upstream specified", 2011-02-09), but as of 045fac5845 > ("i18n: git-parse-remote.sh:

[PATCH v3] parse-remote: remove reference to unused op_prep

2017-02-04 Thread Siddharth Kannan
The error_on_missing_default_upstream helper function learned to take op_prep argument with 15a147e618 ("rebase: use @{upstream} if no upstream specified", 2011-02-09), but as of 045fac5845 ("i18n: git-parse-remote.sh: mark strings for translation", 2016-04-19), the argument is no longer used. Re