On Mon, Apr 30, 2018 at 6:19 PM, Elijah Newren wrote:
> Hi Duy,
>
> On Mon, Apr 30, 2018 at 7:45 AM, Duy Nguyen wrote:
>> On Mon, Apr 30, 2018 at 4:42 PM, Duy Nguyen wrote:
>>> On Sun, Apr 29, 2018 at 10:53 PM, Johannes Schindelin
>>> wrote:
> > @@ -1412,12 +1422,13 @@ int unpack_trees(unsi
Hi Duy,
On Mon, Apr 30, 2018 at 7:45 AM, Duy Nguyen wrote:
> On Mon, Apr 30, 2018 at 4:42 PM, Duy Nguyen wrote:
>> On Sun, Apr 29, 2018 at 10:53 PM, Johannes Schindelin
>> wrote:
> @@ -1412,12 +1422,13 @@ int unpack_trees(unsigned len, struct tree_desc
> *t, struct unpack_trees_optio
On Mon, Apr 30, 2018 at 4:42 PM, Duy Nguyen wrote:
> On Sun, Apr 29, 2018 at 10:53 PM, Johannes Schindelin
> wrote:
>>> > @@ -1412,12 +1422,13 @@ int unpack_trees(unsigned len, struct tree_desc
>>> > *t, struct unpack_trees_options
>>> > WRITE_TR
On Sun, Apr 29, 2018 at 10:53 PM, Johannes Schindelin
wrote:
>> > @@ -1412,12 +1422,13 @@ int unpack_trees(unsigned len, struct tree_desc
>> > *t, struct unpack_trees_options
>> > WRITE_TREE_SILENT |
>> >
Hi Duy,
On Sun, 29 Apr 2018, Duy Nguyen wrote:
> On Tue, Apr 24, 2018 at 8:50 AM, Elijah Newren wrote:
> > Currently, all callers of unpack_trees() set o->src_index == o->dst_index.
> > The code in unpack_trees() does not correctly handle them being different.
> > There are two separate issues:
On Tue, Apr 24, 2018 at 8:50 AM, Elijah Newren wrote:
> Currently, all callers of unpack_trees() set o->src_index == o->dst_index.
> The code in unpack_trees() does not correctly handle them being different.
> There are two separate issues:
>
> First, there is the possibility of memory corruption.
Currently, all callers of unpack_trees() set o->src_index == o->dst_index.
The code in unpack_trees() does not correctly handle them being different.
There are two separate issues:
First, there is the possibility of memory corruption. Since
unpack_trees() creates a temporary index in o->result an
7 matches
Mail list logo