Re: [PATCH v3 0/1] CRLF-Handling: bug fix around ce_compare_data()

2016-05-16 Thread Torsten Bögershausen
On 05/16/2016 06:13 PM, Junio C Hamano wrote: Wait a minute, please. I only asked the reason why you did it that way and mentioned that the end result seemed equivalent. "The end result seems equivalent" does not automatically mean "therefore you must avoid changing the code." If you still pre

Re: [PATCH v3 0/1] CRLF-Handling: bug fix around ce_compare_data()

2016-05-16 Thread Junio C Hamano
tbo...@web.de writes: > From: Torsten Bögershausen > > Changes since v2: > > - Only 1 patch, the t6038 needs to go as a separate "series" > > has_cr_in_index() uses either > data = read_sha1_file(sha1, &type, &sz); > or > data = read_blob_data_from_cache(path, &sz); > > (I like v2 bet

[PATCH v3 0/1] CRLF-Handling: bug fix around ce_compare_data()

2016-05-16 Thread tboegi
From: Torsten Bögershausen Changes since v2: - Only 1 patch, the t6038 needs to go as a separate "series" has_cr_in_index() uses either data = read_sha1_file(sha1, &type, &sz); or data = read_blob_data_from_cache(path, &sz); (I like v2 better, since there is a single code to ge