Re: [PATCH v3 0/2] Incremental rewrite of git-submodules

2018-01-16 Thread Junio C Hamano
Prathamesh Chavan writes: > Changes in v3: > > * For the variables: super_config_url and sub_origin_url, xstrdup() was used > while assigning "" to them, before freeing. > > * In case of the function deinit_submodule, since the orignal code doesn't die > upon failure of

[PATCH v3 0/2] Incremental rewrite of git-submodules

2018-01-14 Thread Prathamesh Chavan
Changes in v3: * For the variables: super_config_url and sub_origin_url, xstrdup() was used while assigning "" to them, before freeing. * In case of the function deinit_submodule, since the orignal code doesn't die upon failure of the function mkdir(), printf was used instead of die_errno.