Re: [PATCH v3 0/3] config: add '--sources' option to print the source of a config value

2016-02-13 Thread Junio C Hamano
Jeff King writes: > I'm actually opposed to "--verbose" because it is too vague. That is > fine for a human, but this is also an interface that we expect scripts > to parse, and which we therefore cannot later change without breaking > them. I am not prepared to set "--verbose" in stone as showin

Re: [PATCH v3 0/3] config: add '--sources' option to print the source of a config value

2016-02-13 Thread Jeff King
On Sat, Feb 13, 2016 at 09:43:34AM -0500, Mike Rappazzo wrote: > > I renamed the flag from "--source" to "--show-origin" as I got the > > impression > > that Sebastian, Peff and Ramsay seem to be all OK with "--show-origin". > > I know that I am late to the party here, but why not make the optio

Re: [PATCH v3 0/3] config: add '--sources' option to print the source of a config value

2016-02-13 Thread Sebastian Schuberth
On Sat, Feb 13, 2016 at 3:43 PM, Mike Rappazzo wrote: >> I renamed the flag from "--source" to "--show-origin" as I got the impression >> that Sebastian, Peff and Ramsay seem to be all OK with "--show-origin". > > I know that I am late to the party here, but why not make the option > `--verbose`

Re: [PATCH v3 0/3] config: add '--sources' option to print the source of a config value

2016-02-13 Thread Mike Rappazzo
On Sat, Feb 13, 2016 at 9:24 AM, wrote: > From: Lars Schneider > > diff to v2: > * rename cmd to cmdline > * rename function current_config_name to current_config_type_name > * add 'type' to config_source struct that identifies config type > * fix config stdin error output and add test case "inv

[PATCH v3 0/3] config: add '--sources' option to print the source of a config value

2016-02-13 Thread larsxschneider
From: Lars Schneider diff to v2: * rename cmd to cmdline * rename function current_config_name to current_config_type_name * add 'type' to config_source struct that identifies config type * fix config stdin error output and add test case "invalid stdin config" * change delimiter between type and