Re: [PATCH v3 0/6] fix repo name when cloning a server's root

2015-08-06 Thread Torsten Bögershausen
On 2015-08-05 23.19, Jeff King wrote: On Wed, Aug 05, 2015 at 10:34:34AM -0700, Junio C Hamano wrote: As you can see, there is a lot of complexity in there and I'm not convinced this is better than just exposing 'parse_connect_url()', which already handles everything for us. I try expose and

Re: [PATCH v3 0/6] fix repo name when cloning a server's root

2015-08-06 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: It is easy to strip the foo:: part of the url, assume that the remote helper uses a RFC 3986 similar url syntax, so that we can feed the reminding https://host/repo.git into the parser (see above). The thing that worries me is that foo:: syntax and

Re: [PATCH v3 0/6] fix repo name when cloning a server's root

2015-08-05 Thread Junio C Hamano
Patrick Steinhardt p...@pks.im writes: - The naive way of just adding '@' as path separator would break cloning repositories like '/foo/b...@baz.git' (which would currently become 'bar@baz' but would become 'baz' only). - Skipping the scheme initially is required because without it

Re: [PATCH v3 0/6] fix repo name when cloning a server's root

2015-08-05 Thread Jeff King
On Wed, Aug 05, 2015 at 10:34:34AM -0700, Junio C Hamano wrote: As you can see, there is a lot of complexity in there and I'm not convinced this is better than just exposing 'parse_connect_url()', which already handles everything for us. If the function handles everything for us, that's

[PATCH v3 0/6] fix repo name when cloning a server's root

2015-08-04 Thread Patrick Steinhardt
This is the third version of this patch series. It aims to improve guessing directory names such that we do not include authentication data and port numbers in them. This version drops the patches exposing 'parse_connect_url()' and instead does the stripping of authentification data and port