Re: [PATCH v3 0/9] Let log-tree and friends respect diffopt's `file` field

Hi Johannes, On Tue, Jun 21, 2016 at 10:12 PM, Johannes Schindelin wrote: > Hi Paul, > > On Tue, 21 Jun 2016, Paul Tan wrote: > >> On Tue, Jun 21, 2016 at 6:34 PM, Johannes Schindelin >> wrote: >> > - this uncovered a problem with builtin

Re: [PATCH v3 0/9] Let log-tree and friends respect diffopt's `file` field

Hi Paul, On Tue, 21 Jun 2016, Paul Tan wrote: > On Tue, Jun 21, 2016 at 6:34 PM, Johannes Schindelin > wrote: > > - this uncovered a problem with builtin am, where it asked the diff > > machinery to close the file stream, but actually called the log_tree > >

Re: [PATCH v3 0/9] Let log-tree and friends respect diffopt's `file` field

Hi Johannes, On Tue, Jun 21, 2016 at 6:34 PM, Johannes Schindelin wrote: > - this uncovered a problem with builtin am, where it asked the diff > machinery to close the file stream, but actually called the log_tree > machinery (which might mean that this patch

[PATCH v3 0/9] Let log-tree and friends respect diffopt's `file` field

The idea is to allow callers to redirect log-tree's output to a file without having to freopen() stdout (which would modify global state, a big no-no-no for library functions). I reviewed log-tree.c, graph.c, line-log.c, builtin/shortlog.c and builtin/log.c line by line to ensure that all calls