Re: [PATCH v3 00/25] object_id part 10

2017-10-16 Thread Junio C Hamano
"brian m. carlson" writes: > On Mon, Oct 16, 2017 at 11:15:34AM +0900, Junio C Hamano wrote: >> With a hope that this might help other reviewers, here is the >> interdiff between "the previous one merged with v2.15-rc1" and "this >> round applied on v2.15-rc1

Re: [PATCH v3 00/25] object_id part 10

2017-10-16 Thread Kevin Daudt
On Mon, Oct 16, 2017 at 11:49:13PM +, brian m. carlson wrote: > On Mon, Oct 16, 2017 at 11:15:34AM +0900, Junio C Hamano wrote: > > With a hope that this might help other reviewers, here is the > > interdiff between "the previous one merged with v2.15-rc1" and "this > > round applied on

Re: [PATCH v3 00/25] object_id part 10

2017-10-16 Thread brian m. carlson
On Mon, Oct 16, 2017 at 11:15:34AM +0900, Junio C Hamano wrote: > With a hope that this might help other reviewers, here is the > interdiff between "the previous one merged with v2.15-rc1" and "this > round applied on v2.15-rc1 directly". > > The changes all looked sensible to me. Thanks. Is

Re: [PATCH v3 00/25] object_id part 10

2017-10-15 Thread Junio C Hamano
"brian m. carlson" writes: > This is the tenth in a series of patches to convert from unsigned char > [20] to struct object_id. This series mostly involves changes to the > refs code. After these changes, there are almost no references to > unsigned char in the

[PATCH v3 00/25] object_id part 10

2017-10-15 Thread brian m. carlson
This is the tenth in a series of patches to convert from unsigned char [20] to struct object_id. This series mostly involves changes to the refs code. After these changes, there are almost no references to unsigned char in the main refs code. In this iteration, I chose to skip the ALLOC_ARRAY