Re: [PATCH v3 01/10] connect: in ref advertisement, shallows are last

On Tue, 3 Oct 2017 13:14:58 -0700 Brandon Williams wrote: > +static int process_dummy_ref(void) > +{ > + struct object_id oid; > + const char *name; > + > + if (parse_oid_hex(packet_buffer, , )) > + return 0; > + if (*name != ' ') > +

[PATCH v3 01/10] connect: in ref advertisement, shallows are last

From: Jonathan Tan Currently, get_remote_heads() parses the ref advertisement in one loop, allowing refs and shallow lines to intersperse, despite this not being allowed by the specification. Refactor get_remote_heads() to use two loops instead, enforcing that refs come