Re: [PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments

2012-09-18 Thread Junio C Hamano
Jeff King p...@peff.net writes: What I think would be much more productive is breaking apart gigantic includes like cache.h into more reasonable modules, which would mean less frequent recompilation when an uninteresting part of the header changes. Ideally cache.h should cover what

Re: [PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments

2012-09-17 Thread Michael Haggerty
On 09/10/2012 10:56 PM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: diff --git a/fetch-pack.h b/fetch-pack.h index 1dbe90f..a6a8a73 100644 --- a/fetch-pack.h +++ b/fetch-pack.h @@ -1,6 +1,8 @@ #ifndef FETCH_PACK_H #define FETCH_PACK_H +#include string-list.h

Re: [PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments

2012-09-17 Thread Jeff King
On Mon, Sep 17, 2012 at 03:10:07PM -0700, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: But how far should this policy be taken? It seems to me that strict adherence to the policy would dictate that *.h files should *never* include other git project files. I

Re: [PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments

2012-09-10 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: Instead of juggling nr_heads,heads (sometimes called nr_match,match), pass around the list of references to be sought in a single string_list variable called sought. Future commits will make more use of string_list functionality. Signed-off-by:

[PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments

2012-09-09 Thread Michael Haggerty
Instead of juggling nr_heads,heads (sometimes called nr_match,match), pass around the list of references to be sought in a single string_list variable called sought. Future commits will make more use of string_list functionality. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu ---