Re: [PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

2017-05-21 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> Looks good. >> >> I however wonder if it is a better approach in the longer term to >> treat the .ignore_case field just like .extended_regexp_option >> field, i.e. not committing immediately to .regflags but commit it >> after config and command line parsing is

Re: [PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

2017-05-20 Thread Ævar Arnfjörð Bjarmason
On Sun, May 21, 2017 at 1:50 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Make the --regexp-ignore-case option work with --perl-regexp. This >> never worked, and there was no test for this. Fix the bug and add a >> test. >> >> When PCRE support was added in commit 63e7e9d8b6

Re: [PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

2017-05-20 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Make the --regexp-ignore-case option work with --perl-regexp. This > never worked, and there was no test for this. Fix the bug and add a > test. > > When PCRE support was added in commit 63e7e9d8b6 ("git-grep: Learn > PCRE", 2011-05-09) compile_pcre_regexp() wou

[PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

2017-05-20 Thread Ævar Arnfjörð Bjarmason
Make the --regexp-ignore-case option work with --perl-regexp. This never worked, and there was no test for this. Fix the bug and add a test. When PCRE support was added in commit 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09) compile_pcre_regexp() would only check opt->ignore_case, but when the -