Re: [PATCH v3 06/24] multi-pack-index: load into memory

2018-07-12 Thread Derrick Stolee
On 7/9/2018 3:08 PM, Junio C Hamano wrote: Derrick Stolee writes: diff --git a/midx.h b/midx.h index dbdbe9f873..2d83dd9ec1 100644 --- a/midx.h +++ b/midx.h @@ -1,6 +1,10 @@ #ifndef __MIDX_H__ #define __MIDX_H__ +struct multi_pack_index; I actually was quite surprised that this struct

Re: [PATCH v3 06/24] multi-pack-index: load into memory

2018-07-09 Thread Junio C Hamano
Derrick Stolee writes: > +struct multi_pack_index *load_multi_pack_index(const char *object_dir) > +{ > + struct multi_pack_index *m = NULL; > + int fd; > + struct stat st; > + size_t midx_size; > + void *midx_map = NULL; > + uint32_t hash_version; > + char *midx_name

Re: [PATCH v3 06/24] multi-pack-index: load into memory

2018-07-05 Thread Eric Sunshine
On Fri, Jul 6, 2018 at 12:19 AM Eric Sunshine wrote: > On Thu, Jul 5, 2018 at 8:53 PM Derrick Stolee wrote: > > +midx_read_expect () { > > + cat >expect <<-EOF > > + header: 4d494458 1 0 0 > > + object_dir: . > > + EOF > > + test-tool read-midx . >actual && > > +

Re: [PATCH v3 06/24] multi-pack-index: load into memory

2018-07-05 Thread Eric Sunshine
On Thu, Jul 5, 2018 at 8:53 PM Derrick Stolee wrote: > Create a new multi_pack_index struct for loading multi-pack-indexes into > memory. Create a test-tool builtin for reading basic information about > that multi-pack-index to verify the correct data is written. > > Signed-off-by: Derrick Stolee

[PATCH v3 06/24] multi-pack-index: load into memory

2018-07-05 Thread Derrick Stolee
Create a new multi_pack_index struct for loading multi-pack-indexes into memory. Create a test-tool builtin for reading basic information about that multi-pack-index to verify the correct data is written. Signed-off-by: Derrick Stolee --- Makefile| 1 + midx.c