Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions

2013-06-11 Thread Junio C Hamano
Célestin Matte celestin.ma...@ensimag.fr writes: Subroutines' parameters should be affected to variable before doing anything else Besides, existing instruction affected a variable inside a if, which break Git's coding style I think s/affect/assign/g is what you meant. By the way, I often

Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions

2013-06-11 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: my ($namespace) = @_; my $namespace = shift; My impression has been that both are equally common, The second is the most common in git-remote-mediawiki (but I don't have any preference nor know what is recommended elsewhere). I

Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions

2013-06-11 Thread Célestin Matte
Le 11/06/2013 20:09, Junio C Hamano a écrit : Matthieu Moy matthieu@grenoble-inp.fr writes: my ($namespace) = @_; my $namespace = shift; My impression has been that both are equally common, The second is the most common in git-remote-mediawiki (but I don't have any

Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions

2013-06-11 Thread Junio C Hamano
Célestin Matte celestin.ma...@ensimag.fr writes: Le 11/06/2013 20:09, Junio C Hamano a écrit : Matthieu Moy matthieu@grenoble-inp.fr writes: my ($namespace) = @_; my $namespace = shift; My impression has been that both are equally common, The second is the most common in

[PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions

2013-06-09 Thread Célestin Matte
Subroutines' parameters should be affected to variable before doing anything else Besides, existing instruction affected a variable inside a if, which break Git's coding style Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr ---