Re: [PATCH v3 08/28] shallow.c: add mark_new_shallow_refs()

2013-11-26 Thread Duy Nguyen
On Tue, Nov 26, 2013 at 5:20 AM, Junio C Hamano gits...@pobox.com wrote: Hmph. the use of -util field in this patch feels that it was something commit-slab data structure was invented to solve. Good stuff! Thanks. + if (c-util == NULL) + c-util = bitmap; +

Re: [PATCH v3 08/28] shallow.c: add mark_new_shallow_refs()

2013-11-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: When we receive a pack and the shallow points from another repository, we may need to add more shallow points to current repo to make sure no commits point to nowhere. But usually we don't want to do so because (in future) new shallow points

[PATCH v3 08/28] shallow.c: add mark_new_shallow_refs()

2013-11-24 Thread Nguyễn Thái Ngọc Duy
When we receive a pack and the shallow points from another repository, we may need to add more shallow points to current repo to make sure no commits point to nowhere. But usually we don't want to do so because (in future) new shallow points invalidate pack bitmaps and we need to rebuild them