[PATCH v3 09/16] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-30 Thread Karthik Nayak
The "%(symref)" atom doesn't work when used with the ':short' modifier because we strictly match only 'symref' for setting the 'need_symref' indicator. Fix this by using comparing with valid_atom rather than used_atom. Add tests for %(symref) and %(symref:short) while we're here. Helped-by: Junio

Re: [PATCH v3 09/16] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-30 Thread Junio C Hamano
Karthik Nayak writes: > The "%(symref)" atom doesn't work when used with the ':short' modifier > because we strictly match only 'symref' for setting the 'need_symref' > indicator. Fix this by using comparing with valid_atom rather than used_atom. > > Add tests for %(symref) and %(symref:short) wh

Re: [PATCH v3 09/16] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-04-01 Thread Karthik Nayak
On Thu, Mar 31, 2016 at 3:47 AM, Junio C Hamano wrote: > Karthik Nayak writes: > >> The "%(symref)" atom doesn't work when used with the ':short' modifier >> because we strictly match only 'symref' for setting the 'need_symref' >> indicator. Fix this by using comparing with valid_atom rather than